Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Remove FeedHandler class #1166

Merged
merged 1 commit into from
Apr 23, 2022
Merged

breaking: Remove FeedHandler class #1166

merged 1 commit into from
Apr 23, 2022

Conversation

fb55
Copy link
Owner

@fb55 fb55 commented Apr 23, 2022

To migrate, change

const handler = new FeedHandler((err) =>
    cb(err, handler.feed)
);

to

const handler = new DomHandler((err) =>
    cb(err, getFeed(handler.dom))
);

To migrate, change

```js
const handler = new FeedHandler((err) =>
    cb(err, handler.feed)
)
```

to

```js
const handler = new DomHandler((err) =>
    cb(err, getFeed(handler.dom))
);
```
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2211907891

  • 20 of 20 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 99.222%

Totals Coverage Status
Change from base Build 2207460022: 0.2%
Covered Lines: 1914
Relevant Lines: 1929

💛 - Coveralls

@fb55 fb55 merged commit 7b8a2f3 into master Apr 23, 2022
@fb55 fb55 deleted the rm-feedhandler branch April 23, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants